Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove missed reference to workspace inheritance in unstable.md #11001

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

Muscraft
Copy link
Member

@Muscraft Muscraft commented Aug 17, 2022

Currently on the nightly docs, workspace inheritance is under the stable table and the unstable table. It looks like I forgot to remove it from the unstable table when working on stabilization.

I am not sure if it is worth a beta backport but I will happily open a PR for it if needed.

@rust-highfive
Copy link

r? @weihanglo

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 17, 2022
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 My impression is that you did remove these. Never mind. LGTM!

A beta backport is welcome!

@weihanglo
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Aug 17, 2022

📌 Commit a5a98f6 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 17, 2022
@bors
Copy link
Contributor

bors commented Aug 17, 2022

⌛ Testing commit a5a98f6 with merge 3b4df5a...

@bors
Copy link
Contributor

bors commented Aug 17, 2022

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 3b4df5a to master...

@bors bors merged commit 3b4df5a into rust-lang:master Aug 17, 2022
bors added a commit that referenced this pull request Aug 17, 2022
beta backport: remove missed reference to workspace inheritance in unstable.md

This is a beta backport of #11001

Currently, on the nightly docs, workspace inheritance is [under the  stable table](https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#workspace-inheritance-1)  and the [unstable table](https://doc.rust-lang.org/nightly/cargo/reference/unstable.html#workspace-inheritance). It looks like I forgot to remove it from the unstable table when working on stabilization.

I think I did this right. If I didn't please let me know!
@Muscraft Muscraft deleted the fix-unstable-docs branch August 17, 2022 21:07
bors added a commit to rust-lang-ci/rust that referenced this pull request Aug 24, 2022
Update cargo

7 commits in 9809f8ff33c2b998919fd0432c626f0f7323697a..6da726708a4406f31f996d813790818dce837161
2022-08-16 22:10:06 +0000 to 2022-08-23 21:39:56 +0000
- Update non-ASCII crate name warning message (rust-lang/cargo#11017)
- Add more tests for aggressive or precise update (rust-lang/cargo#11011)
- Ignore broken but excluded file during traversing (rust-lang/cargo#11008)
- Improve error message for wrong target names (rust-lang/cargo#10999)
- Bump snapbox to 0.3 (rust-lang/cargo#11005)
- remove missed reference to workspace inheritance in unstable.md (rust-lang/cargo#11001)
- Warning when precise or aggressive without -p flag (rust-lang/cargo#10988)
@ehuss ehuss added this to the 1.64.0 milestone Aug 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants