refactor(test): Clarify asserts are for UI #10778
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In writing the contrib documentation for functional vs ui tests, I realized that as we work to make snapbox work for the functional tests, we'll need distinct `Assert` objects since we'll want to elide a lot more content in functional tests. I'm making room for this by qualifying the existing asserts as being for "ui".
|
r? @ehuss (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
👍 @bors r+ |
|
📌 Commit cbd4edb has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 29, 2022
Update cargo 2 commits in a5e08c4703f202e30cdaf80ca3e7c00baa59c496..dbff32b27893b899ae2397f3d56d1be111041d56 2022-06-23 20:12:03 +0000 to 2022-06-24 19:25:13 +0000 - Fetch GitHub commits by long hash more efficiently (rust-lang/cargo#10079) - refactor(test): Clarify asserts are for UI (rust-lang/cargo#10778)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In writing the contrib documentation for functional vs ui tests, I
realized that as we work to make snapbox work for the functional tests,
we'll need distinct
Assertobjects since we'll want to elide a lotmore content in functional tests. I'm making room for this by
qualifying the existing asserts as being for "ui".