Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid downcasting to ProcessError #10163

Closed
wants to merge 1 commit into from

Conversation

kornelski
Copy link
Contributor

An example of change for #10160

@rust-highfive
Copy link

r? @Eh2406

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Dec 4, 2021
@kornelski kornelski force-pushed the procerr branch 2 times, most recently from 35bf44b to f2d1568 Compare December 4, 2021 23:47
@alexcrichton
Copy link
Member

Personally I don't think we should merge PRs like this until #10160 is settled. While good for informational purposes I otherwise think it would be best to further discussion of #10160 before reaching for more PRs.

@joshtriplett
Copy link
Member

Closing per #10163 (comment) .

@kornelski kornelski deleted the procerr branch February 1, 2022 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants