Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"cargo clean" puts lock on package cache #7490

Closed
matthiaskrgr opened this issue Oct 7, 2019 · 2 comments · Fixed by #7502
Closed

"cargo clean" puts lock on package cache #7490

matthiaskrgr opened this issue Oct 7, 2019 · 2 comments · Fixed by #7502
Labels

Comments

@matthiaskrgr
Copy link
Member

Problem
cargo clean puts a lock on the package cache (cargo home) but I think it should not need it at all?

Steps

  1. Have cargo fetch of some git repo run on project 1.
  2. Try to cargo clean a different repo at the same time
    =>
    Blocking waiting for file lock on package cache

Possible Solution(s)
I don't really see why we need to take the $CARGO_HOME lock into account here, after all we only need to rm -rf target..?

Notes

Output of cargo version:
cargo 1.40.0-nightly (8b0561d68 2019-09-30)

@matthiaskrgr matthiaskrgr added the C-bug Category: bug label Oct 7, 2019
@ehuss
Copy link
Contributor

ehuss commented Oct 10, 2019

I think it would be fine to move this line below line 63 if you want to fix this.

@matthiaskrgr
Copy link
Member Author

Thanks!

bors added a commit that referenced this issue Oct 10, 2019
don't lock the package cache when cleaning target dir.

Fixes #7490
@bors bors closed this as completed in 9883d20 Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants