Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default features of dependencies get pulled in for no reason #3768

Closed
nox opened this issue Feb 27, 2017 · 1 comment · Fixed by #3771
Closed

Default features of dependencies get pulled in for no reason #3768

nox opened this issue Feb 27, 2017 · 1 comment · Fixed by #3771

Comments

@nox
Copy link
Contributor

nox commented Feb 27, 2017

With cargo 0.18.0-nightly (8a15098 2017-02-27), building Servo concludes with the following error:

error: failed to run custom build command for `webrender_traits v0.20.0 (https://github.com/servo/webrender#fc720d07)`
process didn't exit successfully: `/Users/nox/src/servo-2/target/release/build/webrender_traits-1eea1881688067a6/build-script-build` (exit code: 101)
--- stderr
thread 'main' panicked at 'serde_codegen and serde_derive are both used. You probably forgot --no-default-features.', /Users/nox/.cargo/git/checkouts/webrender-c3596abe1cf4f320/fc720d0/webrender_traits/build.rs:31
note: Run with `RUST_BACKTRACE=1` for a backtrace.

We still have the same setup for webrender and webrender_traits as in #3164.
@nox
Copy link
Contributor Author

nox commented Feb 27, 2017

The bug is somewhere in 385e243...8a15098.

alexcrichton added a commit to alexcrichton/cargo that referenced this issue Feb 27, 2017
@alexcrichton
Accept default_features for default-features
fd25593 
This was accepted by this historical TOML parser, so we'll need to preserve this
ability.

Closes rust-lang#3768
@alexcrichton alexcrichton mentioned this issue Feb 27, 2017
Merged
bors added a commit that referenced this issue Feb 28, 2017
@bors
Auto merge of #3771 - alexcrichton:read-more, r=matklad
09b68aa 
Accept `default_features` for `default-features`

This was accepted by this historical TOML parser, so we'll need to preserve this
ability.

Closes #3768
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Accept default_features for default-features alexcrichton/cargo
1 participant
@nox