Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting quiet from config #10128

Closed
frioux opened this issue Nov 27, 2021 · 2 comments · Fixed by #10152
Closed

Allow setting quiet from config #10128

frioux opened this issue Nov 27, 2021 · 2 comments · Fixed by #10152
Labels
A-configuration Area: cargo config files and env vars A-console-output Area: Terminal output, colors, progress bar, etc. C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`

Comments

@frioux
Copy link

frioux commented Nov 27, 2021

Problem

I prefer the output to be --quiet and would like to set it as a config option.

Proposed Solution

I'd like to be able to set quiet in config.toml just like you can set verbose. Maybe something like this:

[term]
quiet = true

If people think this is a reasonable idea I'd be happy to try my hand at implementing it.

Notes

No response

@frioux frioux added the C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted` label Nov 27, 2021
@ehuss
Copy link
Contributor

ehuss commented Nov 30, 2021

Sounds reasonable to me. There are some details about the exact behavior when mixing flags that this should be careful about. I think people may have different opinions about how it should work, but I'm thinking of something like the following:

  • --verbose and --quiet CLI options take precedent over anything set in config.
  • You can't set both verbose and quiet in config (it is an error).

Otherwise, let me know if you have any questions.

@ehuss ehuss added A-configuration Area: cargo config files and env vars A-console-output Area: Terminal output, colors, progress bar, etc. labels Nov 30, 2021
@frioux
Copy link
Author

frioux commented Nov 30, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-configuration Area: cargo config files and env vars A-console-output Area: Terminal output, colors, progress bar, etc. C-feature-request Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants