Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unapprove on push #120

Merged
merged 4 commits into from
Aug 14, 2024

Conversation

vohoanglong0107
Copy link
Contributor

Almost the same as unapprove on base edit

@vohoanglong0107 vohoanglong0107 marked this pull request as ready for review July 24, 2024 14:21
Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Left a few notes, nothing major.

src/bors/event.rs Outdated Show resolved Hide resolved
src/bors/handlers/review.rs Show resolved Hide resolved
src/bors/handlers/review.rs Outdated Show resolved Hide resolved
src/github/webhook.rs Show resolved Hide resolved
src/bors/handlers/review.rs Outdated Show resolved Hide resolved
@vohoanglong0107
Copy link
Contributor Author

Sorry for the lack of updates on this 😓 I messed up my computer and it's taking awhile to get it up running again

@Kobzol
Copy link
Contributor

Kobzol commented Jul 29, 2024

Absolutely no worries. Given that my PhD deadline is in ~30 days, I don't have plenty of time to work on bors atm myself..

Copy link
Contributor

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@Kobzol Kobzol added this pull request to the merge queue Aug 14, 2024
Merged via the queue into rust-lang:main with commit 754b7f3 Aug 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants