fix: slight grammar mistake in ch15-02 #3717
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriskrycho
reviewed
Apr 2, 2024
There was a problem hiding this comment.
Thanks for opening this! This is an interesting case where both forms are legitimate English. I agree that your suggestion is slightly more idiomatic, but only slightly, so in the interest of only making changes which are clear correctness issues or significant improvements, given the overhead involved in updating the physical copy of the book, I am going to leave this one as is. Thanks again!
|
Thanks for reviewing! I looked into it more at the time and I found that they are both correct as well. Makes sense to not commit due to the tradeoffs. Thanks again and cheers! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.