PR 2363's use of &T made Copy/Clone traits unnecessary in section 10.2 #2580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmazin
changed the title
|
Thanks, but I decided to go with the fix in #2460 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #2363, @steveklabnik changed Listing 10-5 to use &T. Seems like one of the goals was to avoid messiness related to Copy/Clone.
I noticed that this section used an old version of Listing 10-5, so I updated it to use the new version of Listing 10-5. Given that listing 10-5 avoids messiness related to Copy/Clone, adding the PartialOrd trait is enough to make listings/ch10-generic-types-traits-and-lifetimes/no-listing-07-fixing-listing-10-05/src/main.rs compile happily.
Listing 10-15 is no longer required. I'm not sure what y'all do when a listing is removed -- I don't know if Listings 10-16+ need to be renumbered.