Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 128-bit ints to ch3 #1230

Merged
merged 4 commits into from
Mar 21, 2018
Merged

Add 128-bit ints to ch3 #1230

merged 4 commits into from
Mar 21, 2018

Conversation

mark-i-m
Copy link
Member

128-bit ints are being stabilized.

cc rust-lang/rust#35118

@steveklabnik
Copy link
Member

New features need to go in https://github.com/rust-lang/book/blob/master/second-edition/src/appendix-06-newest-features.md, could you put this there please? Thank you!

@mark-i-m
Copy link
Member Author

@steveklabnik in addition to, or in stead of the changes I have here?

@steveklabnik
Copy link
Member

steveklabnik commented Mar 18, 2018 via email

@mark-i-m
Copy link
Member Author

@steveklabnik Thanks! Done. Let me know if you want me to squash...

Copy link
Member

@steveklabnik steveklabnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Don't worry about the squash, it's fine.

@steveklabnik
Copy link
Member

Gah, would you mind adding LLVM, natively, and cryptographic` to https://github.com/rust-lang/book/blob/master/second-edition/dictionary.txt? we can merge right after.

@mark-i-m
Copy link
Member Author

@steveklabnik Done.

Copy link
Member

@carols10cents carols10cents left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@carols10cents carols10cents merged commit d77c067 into rust-lang:master Mar 21, 2018
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Mar 23, 2018
Stabilize 128-bit integers 🎉

cc rust-lang#35118

EDIT: This should be merged only after the following have been merged:
- [x] rust-lang/compiler-builtins#236
- [x] rust-lang/book#1230
bors added a commit to rust-lang/rust that referenced this pull request Mar 26, 2018
Stabilize 128-bit integers 🎉

cc #35118

EDIT: This should be merged only after the following have been merged:
- [x] rust-lang/compiler-builtins#236
- [x] rust-lang/book#1230
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants