Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust 2024 call for testing #1434

Merged
merged 4 commits into from
Nov 27, 2024
Merged

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Nov 23, 2024

This adds a post to ask people to help with the 2024 edition testing.

Post-dated for Monday. I hope to at least have cargo merged tomorrow. There's also a bunch of doc updates, but those probably won't be ready before Monday, so not sure if I should wait another day.

cc @traviscross

Rendered

@weihanglo
Copy link
Member

@ehuss which PR needs to be included in Cargo for testing 2024 edition?

@ehuss
Copy link
Contributor Author

ehuss commented Nov 23, 2024

rust-lang/cargo#14828 (and there are some updates I need to push to that as well), along with updating the submodule in rust-lang/rust (which I can do tonight), and then waiting for that to hit nightly.

@traviscross traviscross self-assigned this Nov 23, 2024
@traviscross
Copy link
Contributor

Status: I've revised the post a bit. It looks like we're still waiting on rust-lang/cargo#14828 to merge and end up in the nightly toolchain. It does make a much cleaner announcement and a better experience for people testing if we let that merge, so we'll see if that can happen. Perhaps this can go out tomorrow. That'd still be OK.

@traviscross
Copy link
Contributor

traviscross commented Nov 26, 2024

OK. We were waiting on rust-lang/rust#133465, which is now merged. Now we just need that in a nightly available via rustup.

@traviscross
Copy link
Contributor

The new nightly is out; I'm testing and preparing to send this out.

@traviscross traviscross force-pushed the 2024-call-for-testing branch 3 times, most recently from 2ebd282 to 04c238f Compare November 27, 2024 04:54
ehuss and others added 4 commits November 27, 2024 04:57
Let's do a bit more to get people excited, and tighten up some
language here.

For the team in the by-line, it'd be best if we had a website for our
team, but for the moment, let's just link to the edition guide rather
than to the team TOML file.
If someone has an older MSRV than `1.85`, the person will hit an
error, so let's describe this step.

We'd probably have done this as a sub bullet point, but the rendering
of that does not look elegant.
@traviscross traviscross marked this pull request as ready for review November 27, 2024 05:12
@traviscross traviscross merged commit f5dcfee into rust-lang:master Nov 27, 2024
3 checks passed
@traviscross
Copy link
Contributor

OK. It's now live. Tells your friends and feel free to post to social media.

https://blog.rust-lang.org/2024/11/27/Rust-2024-public-testing.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants