-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Announce an impending update the Android NDK target #1055
Announce an impending update the Android NDK target #1055
Conversation
88d8106
to
96cead8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, it needs the version number before being merged though
96cead8
to
820b255
Compare
e0f63f1
to
b3ad913
Compare
@chriswailes when would you like this to go live? Could you make sure to update the post's file name to have the right date. Also, don't forget to update the Rust version where the change is supposed to land. |
Is the announcement date up to me? If so, I'll change the date to Monday. What version would the NDK update land in if the PR is accepted next week? Would that be 1.68? |
1.66 stable just released, so you have a 6 week window to make it into 1.68. |
I think we should wait for the PR to land first, no? It would be a shame for the announcement to happen only for the PR to be delayed. |
I'm largely happy with merging this before the PR; the worst case is that folks have a little more time. But in practice we've already landed this once I believe, so I don't anticipate it being difficult to do again. |
b3ad913
to
41b036b
Compare
#1055 (comment) I think still needs to be resolved. |
Yeah, sorry. I'm still not used to GitHub's threading and saw that after I made the last post. |
41b036b
to
9530585
Compare
Co-authored-by: Mark Rousskov <[email protected]>
Announce an impending update the Android NDK target
…roalbini Ndk update redux Blocked on rust-lang/blog.rust-lang.org#1055
Ndk update redux Blocked on rust-lang/blog.rust-lang.org#1055
Ndk update redux Blocked on rust-lang/blog.rust-lang.org#1055
Ndk update redux Blocked on rust-lang/blog.rust-lang.org#1055
The language is a little rough. Please let me know if there is anything I can do to improve the announcement.