Fix display of annotation for double width characters #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magurotuna
commented
Sep 4, 2021
Comment on lines
+638
to
+644
| let expected = r#" --> <current file>:1:1 | ||
| | | ||
| 1 | お寿司 | ||
| | ^^^^^^ Sushi1 | ||
| 2 | 食べたい🍣 | ||
| | ---- note: Sushi2 | ||
| |"#; |
There was a problem hiding this comment.
With monospace fonts, this is displayed like:
magurotuna
commented
Sep 4, 2021
Comment on lines
+601
to
+607
| let expected = r#" --> <current file>:1:3 | ||
| | | ||
| 1 | おはよう | ||
| | _____^ | ||
| 2 | | ございます | ||
| | |______^ Good morning | ||
| |"#; |
magurotuna
commented
Sep 4, 2021
Comment on lines
+573
to
+577
| let expected = r#" --> <current file>:1:7 | ||
| | | ||
| 1 | こんにちは、世界 | ||
| | ^^^^ world | ||
| |"#; |
magurotuna
commented
Sep 4, 2021
Comment on lines
+668
to
+672
| let expected = r#" --> <current file>:1:7 | ||
| | | ||
| 1 | こんにちは、新しいWorld！ | ||
| | ^^^^^^^^^^^ New world | ||
| |"#; |
|
Thank you so much for the patch! It reads very clear and not just fixes the bug, but also improves the code. |
zbraniecki
approved these changes
Sep 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there.
We're using this crate in denoland/deno_lint to display pretty diagnostics of the linter. By chance, I found that this crate doesn't work well if the source includes double width characters like:
Specifically, if we attempt to point to
はin this snippet by passing(15, 16)as range, annotate-snippets will give us:where obviously
^points to the wrong position.These characters take up twice the size of ordinary characters like the alphabet, so displaying annotation for them requires special handling, which I implemented in this patch.