fix(render): On fold, strip prefix/suffix rather than fold #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As `fold` is special machinery, I made that test under that. The others, I couldn't tell what different cases they were covering, so I kept the names. I did name them with the `ann` prefix to highlight these are testing annotations.
As we don't show `...` on non-first lines without fold, it seems to make sense to do the same thing for fold. To show this, we likely would want to add more nuance than just `fold`. This has the benefit of offering a "magic mode" where the annotated lines get selected automatically. This was implemented by pre-processing things which should keep overhead low as other calculations down the line aren't done.
Muscraft
approved these changes
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we don't show
...on non-first lines without fold, it seems to makesense to do the same thing for fold.
To show this, we likely would want to add more nuance than just
fold.This has the benefit of offering a "magic mode" where the annotated
lines get selected automatically.
This was implemented by pre-processing things which should keep overhead
low as other calculations down the line aren't done.