cleanup and fix coherence rules #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more idiomatic formality than ui-test and easier to manage. It allows you to group tests into files and to run tests with rust-analyzer's builtin facilities. We will eventually I think want to move to ui tests again but with actual rust inputs this time.
joint work with lcnr + errs
|
r? @lcnr |
|
r? lcnr |
lcnr
reviewed
May 14, 2024
Comment on lines
+107
to
+108
| // If we can normalize `goal` to something else, and that normalized | ||
| // form may be downstream. |
There was a problem hiding this comment.
// If `parameter` is an alias which refers a type which may be
// from a downstream crate, it may be normalized to that type,
// so recurse into it.
//
// We only do so if the alias cannot be normalized to a type which
// is definitely not a downstream parameter.
|
woops, forgot i've added a nit |
|
applied it directly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR actually does two things that really ought not to be combined but I am lazy:
Fixes #157