Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

5.7 Error Handling #193

Merged
merged 2 commits into from
Jan 28, 2017
Merged

5.7 Error Handling #193

merged 2 commits into from
Jan 28, 2017

Conversation

KeenS
Copy link
Member

@KeenS KeenS commented Jul 13, 2016

TODO: 見直し

@KeenS
Copy link
Member Author

KeenS commented Dec 12, 2016 •
edited
Loading

確認&修正終わりました。chapter->sectionが多いですがちょくちょく手直しも入ってます。
@tatsuya6502 レビューお願いします。

@KeenS KeenS changed the title [WIP] 5.7 Error Handling 5.7 Error Handling Dec 12, 2016
@tatsuya6502 tatsuya6502 added this to the 1.9 milestone Jan 24, 2017
@tatsuya6502 tatsuya6502 self-requested a review January 24, 2017 01:05
@tatsuya6502
Copy link
Member

tatsuya6502 commented Jan 25, 2017 •
edited
Loading

メモ

現在の master とコンフリクトあり： Rest vs Rust　対応済み
Circle CI: https://circleci.com/gh/rust-lang-ja/the-rust-programming-language-ja/159

@KeenS KeenS force-pushed the 1.9-error-handling branch from 0d0130f to 00c172b Compare January 25, 2017 13:46
@KeenS
Copy link
Member Author

KeenS commented Jan 25, 2017

コンフリクトを解決してmasterにrebaseしました。

tatsuya6502
tatsuya6502 approved these changes Jan 28, 2017
View reviewed changes
Copy link
Member

@tatsuya6502 tatsuya6502 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KeenS レビューOKですので、マージします。

おつかれさまでした！

@tatsuya6502 tatsuya6502 merged commit 866f60d into rust-lang-ja:master Jan 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tatsuya6502 tatsuya6502 tatsuya6502 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.9
Development

Successfully merging this pull request may close these issues.
2 participants
@KeenS @tatsuya6502