Implement PeekingNext for PeekingTakeWhile.
#644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change implements `PeekingNext` for `PeekingTakeWhile` by composing its predicate with the predicate given to `PeekingNext::peeking_next`. This allows subsequent (and chained) calls to functions that require `PeekingNext` following `Itertools::peeking_take_while`.
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
PeekingNextforPeekingTakeWhileby composing its predicate with the predicate given toPeekingNext::peeking_next. This allowsItertools::peeking_take_whileto be chained and for subsequent calls, including those across function boundaries, to function as expected while restoring items in the originating iterator.See also #643, which implements
PeekingNextfor mutable references. In combination, these changes allow code to generically accept types implementingPeekingNextwhereItertools::peeking_take_whilecan be used by the caller to prepare an iterator and subsequently by a function where restoring items in the originating iterator is important (i.e., the function cannot simply useIterator::peekableetc., becauseIterator::nextwould unconditionally be called on the originating iterator).