Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade crate ethereum-types and rlp #59

Merged
merged 2 commits into from
Dec 27, 2024

Conversation

0xbillw
Copy link
Contributor

@0xbillw 0xbillw commented Dec 10, 2024

No description provided.

@nazar-pc
Copy link

This is needed for https://github.com/polkadot-evm/frontier upgrade to polkadot-sdk release stable-2412.
@sorpaas could you take a look, please?

@koushiro
Copy link
Collaborator

@0xbillw please fix the clippy warnings

@0xbillw
Copy link
Contributor Author

0xbillw commented Dec 27, 2024

@0xbillw please fix the clippy warnings

Sorry, I just saw the message. It has been processed, thank you!

@koushiro koushiro merged commit 3be0d8f into rust-ethereum:master Dec 27, 2024
5 checks passed
@0xbillw
Copy link
Contributor Author

0xbillw commented Dec 27, 2024

This is needed for https://github.com/polkadot-evm/frontier upgrade to polkadot-sdk release stable-2412. @sorpaas could you take a look, please?

@nazar-pc Do you know that frontier plans to upgrade polkadot-sdk to release stable2412?
Currently, frontier is based on stable2409, but this version has a memory leak issue, as mentioned here: paritytech/polkadot-sdk#5998 and paritytech/polkadot-sdk#6149.
But now, I am trying to upgrade frontier to stable2412.

@boundless-forest
Copy link

@0xbillw Try to raise an upgrade PR in the Frontier; I'll review and merge it.

@nazar-pc
Copy link

I've been working on upgrade PR, but got stuck on this. Will open later today.

@nazar-pc
Copy link

@koushiro would it be possible to release a new version of the crate with this, please?

@koushiro
Copy link
Collaborator

koushiro commented Dec 27, 2024

@nazar-pc Sorry, I don't have permission to publish this crate, only write permission to this repo.

Based on what I've observed so far, this crate is primarily used in projects within the Polkadot ecosystem.
Perhaps it would be more appropriate to migrate this repo to the primitives part of frontier.

@nazar-pc
Copy link

From the name of the crate it makes sense for it to live under this org, but no strong preference here from me.

@sorpaas looks like you were publishing this before, would appreciate if you can find a minute to do so again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants