-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed sensors, so they can be put in separate crate #28
Conversation
Prior to merging this, the code that has been deleted should first be moved to a new repo. Is this something that we want to create in rust-embedded? Or something that would maybe make sense in someone's personal github area? I don't know that it makes much sense in rust-embedded. Are these libraries something that you want to keep maintaining @posborne? |
I'm fine with maintaining them to some degree. Since individual drivers are pretty small, I wonder if it might make sense to have a single repo with several drivers (possibly not just i2c drivers). Each driver would still be its own crate. I feel this might help with driver maintainability/etc. as we get some scale and infrastructure reuse. Thoughts? Thinking something like |
I agree that putting drivers in single repo is fine if they are small. Especially, if each of them will be separate crate. |
I also agree for a separate crate. |
I don't know on a final location as of yet, but we have been tossing around a few ideas for sync/async traits for doing I2C and other interfacing here: rust-embedded/wg#19 |
Thanks! |
I'm going to close this as it is a little out of date now that we have a more clear path forward for defining things on top of the embedded-hal traits. I still think there might be a place for an umbrella project that maintains multiple sensor crates in a single repository but it probably shouldn't be this repository as it is very tightly coupled to Linux and, ideally, device drivers would have minimal dependencies and be able to work on a |
Fixes #27