HistoryBuffer Add pop_oldest #377
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
what's the use case for this? It seems to me there's a lot of overlap with Deque here. IMO if you need push/pop you should use Deque, and HistoryBuffer should be used only when you want to do "statistics" on the last N values, not as a queue you pop things from. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
There currently is no interface for removing elements from the HistoryBuffer.
Added
HistoryBuffer.pop_oldest()HistoryBuffer.filled()getter to replacefilledmember variableHistoryBuffer.pop_oldest()Changed
HistoryBuffer.len()to be a getter rather than computed on call.HistoryBuffer.write()HistoryBuffer.recent()HistoryBuffer.oldest_ordered()OldestOrdered.next()Warning
HistoryBuffer.as_slice()no longer has the same meaning. The slice returned may contain unused values.