-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
singleton: forward attributes #522
Conversation
This only works in the long form with a named variable because of constraints on where the `vis` metavariable can be used. close rust-embedded#521
The visibility thing might be useless as this ends up in a closure. I'm open to input. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! nice
Supporting attributes looks good and is definitely really useful. I can't tell when the visibility spec could ever make a difference though - the only way anything outside of the macro itself can refer to the storage is by the |
There are certainly ways to access it other than through the |
Oh, true, that wasn't possible before but I suppose it is now. I think ideally the static should not be accessible from outside the macro... but using an I don't think there's any point including the visibility specifier as it seems like it can never make any difference, so I'd rather remove it. |
@adamgreig visibility forwarding removed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This only works in the long form with a named variable because of
constraints on where the
vis
metavariable can be used.close #521