Set ESR_ELX writable #15
Merged
+22
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the Arm Architecture Reference Manual (DDI 0487H.a), sections C5.2.5 and C5.2.6, ESR_EL1 and ESR_EL2 can be written to. Whether the write succeeds depends on which exception level we are running in, but this is not a concern for the aarch64-cpu crate. Implement the Writeable interface for ESR_EL1 and ESR_EL2.
|
This looks good and sensible to me. It is indeed possible to MSR to ESR_ELx. |
nchong-at-aws
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to the Arm Architecture Reference Manual (DDI 0487H.a), sections C5.2.5 and C5.2.6,
ESR_EL1andESR_EL2can be written to. Whether the write succeeds depends on which exception level we are running in, but this is not a concern for the aarch64-cpu crate.Implement the Writeable interface for
ESR_EL1andESR_EL2.