-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move bounded drawing calculation from interfaces into the only call site #113
Move bounded drawing calculation from interfaces into the only call site #113
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, weird that we didn't do this previously. Tested on hardware and looks good to me. Isn't this a breaking change though? Probably nobody is using send_bounded_data
, but it's public. Can you add a breaking changelog entry saying it's been moved private or something?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops wrong button
It's a bit weird that this is a world-public interface. But I've added the entry as requested. |
NB: I've also tested the I2C version of this in one of my projects. |
It should probably be private, no? I'm happy to make that breaking change. If someone really wants it, we can come up with a better solution down the road. p.s. needs a rebase |
@jamwaffles Privatizing doesn't really work, already tried. It's too exposed but hey, maybe we're completely changing it anyways. 😅 |
Signed-off-by: Daniel Egger <[email protected]>
Signed-off-by: Daniel Egger <[email protected]>
ed67528
to
9387c84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Please merge when you want to.
Hi! Thank you for helping out with SSD1306 development!
Please:
master
if you're not already up to dateCHANGELOG.md
entry in the Unreleased section under the appropriate heading (Added, Fixed, Changed, etc)rustfmt
on the project withcargo fmt --all
- CI will not pass without this stepPR description
Remove some code duplication in bounded box drawing by moving the bounding box calculation from the interface specific
send_bounded_data
into the only call site and reuse the regularsend_data
function.