Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sporadic test failure #75

Merged
merged 1 commit into from
Oct 9, 2022
Merged

Conversation

matthiasbeyer
Copy link
Member

Closes #70

@matthiasbeyer
Copy link
Member Author

So that made it work for now. @petreeftime what do you think? Is that enough? Or just a "sporadic success"? 😆

@matthiasbeyer matthiasbeyer marked this pull request as ready for review October 9, 2022 08:26
@matthiasbeyer
Copy link
Member Author

I guess I can

bors try

to see whether this does the trick or fails again...

bors bot added a commit that referenced this pull request Oct 9, 2022
@bors
Copy link
Contributor

bors bot commented Oct 9, 2022

try

Build succeeded:

@petreeftime
Copy link
Collaborator

The error seems to be caused by duplication of output, so I don't know whether this will help. I don't see a reason not to try, but I think there must be something that either was always buggy and interacts poorly with the test env, or caused by some minor change in nix 0.25 vs 0.14 that interacts poorly with the test env.

@petreeftime
Copy link
Collaborator

bors merge

@matthiasbeyer
Copy link
Member Author

What I can think of is that the timeout is too short, and that caused the test to execute the following:

cat 
hans
hans: no such command

or something like that (because cat gets stopped too soon). I don't know for sure, of course, but that's the first thing I could think of.

@matthiasbeyer
Copy link
Member Author

Why does this take so long? Is bors overloaded right now? Weird... 🤔

@bors
Copy link
Contributor

bors bot commented Oct 9, 2022

Build succeeded:

@bors bors bot merged commit 2151dab into rust-cli:master Oct 9, 2022
@matthiasbeyer matthiasbeyer deleted the fix-sporadic-test branch October 9, 2022 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test_read_line fails randomly
2 participants