Fix argument tokenization #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The single and double quotes used to group words into a single command line argument must be trimmed from the tokens. E.g. the argument of `cmd "foo bar"` is the string `"foo bar"` and not `"\"foo bar\""`. Signed-off-by: Didier Wenzek <[email protected]> Signed-off-by: Matthias Beyer <[email protected]>
matthiasbeyer
force-pushed
the
fix-argument-tokenization
branch
from
9b2a54f to
2aa771b
Compare
|
Nice, so it was indeed my local setup that made the tests confused. I guess we can bors merge @didier-wenzek thanks for contributing to this crate. |
|
Build succeeded: |
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The single and double quotes used to group words
into a single command line argument must be trimmed from the tokens.
E.g. the argument of
cmd "foo bar"is the string"foo bar"and not"\"foo bar\"".Tests locally do not run for this, but lets see what CI tells us. Maybe my setup is bogus.
Closes #39