Make exp_any return the earliest result #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is the only way to edit this commit-message to close the PR and open a new one? |
|
No, you can |
matthiasbeyer
requested changes
Sep 12, 2022
souze
force-pushed
the
origin/any-returns-earliest-result
branch
from
ce74614 to
834a9aa
Compare
Previously,
exp_any would return the match with the lowest index in the list.
So this:
exp_any(&vec![ReadUntil::String("hello"), ReadUntil::String("hell")]
With the input from the process as "hello",
will sometimes return "hell", and sometimes "hello".
Depending on how much the readbuffer happened to have collected.
With this change, the earliest match in the input will be matched.
That way, any difference in how much the read buffer has currently
consumed does not change the output of the exp_any function.
Signed-off-by: Erik Karlsson <[email protected]>
souze
force-pushed
the
origin/any-returns-earliest-result
branch
from
834a9aa to
642e718
Compare
matthiasbeyer
approved these changes
Sep 12, 2022
|
I guess we can bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, exp_any would return the match with the lowest index in the list
So this
exp_any(&vec![ReadUntil::String("hello"), ReadUntil::String("hell")]With the input from the process as "hello", will sometimes return "hell", and sometimes "hello", depending on how much the readbuffer happened to have collected.