Fix #208 (Remove pipe for BufferWriter and implement handeling in Writer) #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll write a test today and merge. |
|
Sry for the force push, but at lest the linter fixes are cleaner now. |
mainrs
reviewed
Jul 19, 2021
| WritableTarget::Stdout => print!("{}", String::from_utf8_lossy(&buf.0)), | ||
| WritableTarget::Stderr => eprint!("{}", String::from_utf8_lossy(&buf.0)), | ||
| WritableTarget::Pipe(_) => unreachable!(), |
There was a problem hiding this comment.
Maybe I am missing something quite obvious, but why is this unreachable?
There was a problem hiding this comment.
BufferWriter::pipe was removed, so there is only BufferWriter::stdout and BufferWriter::stderr left to create a BufferWriter and both of those can't have the Pipe Target.
|
Ping @mainrs. |
|
Ping @mainrs |
|
I don't like the extra |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #208
A test would also be nice, so that it hopefully doesn't break again unnoticed. ^^