Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stream): Respect 'test' feature #229

Merged
merged 4 commits into from
Nov 4, 2024
Merged

fix(stream): Respect 'test' feature #229

merged 4 commits into from
Nov 4, 2024

Conversation

epage
Copy link
Collaborator

@epage epage commented Nov 4, 2024

We were putting it into the generated code, not our code, causing it to
be an "unexpected cfg".

It would be nice to use the macro's cfgs in the generated code...

@coveralls
Copy link

coveralls commented Nov 4, 2024

Pull Request Test Coverage Report for Build 11669910165

Details

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.1%) to 51.885%

Totals Coverage Status
Change from base Build 11636143482: 0.1%
Covered Lines: 1225
Relevant Lines: 2361

💛 - Coveralls

We were putting it into the generated code, not our code, causing it to
be an "unexpected cfg".

It would be nice to use the macro's cfgs in the generated code...
@epage epage merged commit d364ac4 into rust-cli:main Nov 4, 2024
14 of 15 checks passed
@epage epage deleted the cfg branch November 4, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants