Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Appveyor CI #152

Closed
wants to merge 1 commit into from
Closed

Conversation

elichai
Copy link
Member

@elichai elichai commented Aug 20, 2019

Hi,
After a bunch of discussions over time on windows and travis,
which is pretty buggy because it's still considered beta.
#147 #148 #84

This Will introduce a separate CI for native windows.
This will check the following:
beta, stable, nightly, 1.22.0
with targets: MSVC,GNU each one 64bit+32bit
emscripten for stable
and test that the benchmarks compile on nightly.

this works with caching.

The big caveat is maintaining two different CIs.
I think it can be partially mitigated by separating the tests themselves into a separate file (though i'm not sure about this file supporting both windows and linux)

but with this we could potentially remove the windows builds from travis and have this in parallel

@elichai
Copy link
Member Author

elichai commented Aug 20, 2019

@real-or-random
Copy link
Collaborator

Nice. MSVC and GNU together is certainly useful. Actually, does Rust on Windows on Travis use MSVC or GNU? I think it's MSVC but I don't know to be honest. Could we enable both on Travis too?

I think it's in general a good idea to have a script that runs all the tests (or one for each OS, even if
they look very similar). This makes it easier to run extensive tests locally.

By the way, I just found this: https://github.com/japaric/trust Maybe it's useful.
Also this is interesting to know: rust-lang/rustup#998 (comment)

@elichai
Copy link
Member Author

elichai commented Aug 21, 2019

I don't know either, although I think it's GNU because Travis somehow accepts GNU like commands (like the ifs in our travis config aren't failing on windows)

@elichai
Copy link
Member Author

elichai commented Aug 21, 2019

@real-or-random Apparently I was wrong. https://travis-ci.org/rust-bitcoin/rust-secp256k1/jobs/574387376#L33

@apoelstra
Copy link
Member

I think we're more likely to move to github CI than to appveyor.

@apoelstra apoelstra closed this Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants