Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MSRV to 1.57.0 to more correctly match the codebase. #1760

Merged
merged 2 commits into from
May 13, 2024

Conversation

martinfrances107
Copy link
Contributor

As the code has been updated new features that break the currently stated MSRV have been added.

I just want the codebase to reflect reality.

This issue can be seen by running cargo clippy

warning: current MSRV (Minimum Supported Rust Version) is `1.56.0` but this item is stable since `1.57.0`
   --> src/traits.rs:649:10
    |
649 |     self.as_slice()
    |          ^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv
    = note: `#[warn(clippy::incompatible_msrv)]` on by default

Cargo.toml Outdated Show resolved Hide resolved
Copy link

codspeed-hq bot commented May 12, 2024

CodSpeed Performance Report

Merging #1760 will degrade performances by 14.2%

Comparing martinfrances107:bump_MSRV (367c529) with main (2560d5c)

Summary

⚡ 1 improvements
❌ 1 regressions
✅ 22 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main martinfrances107:bump_MSRV Change
recognize float str 1 µs 1.2 µs -14.2%
number 287.2 ns 259.4 ns +10.71%

Copy link

codecov bot commented May 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.42%. Comparing base (2560d5c) to head (367c529).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1760      +/-   ##
==========================================
- Coverage   61.47%   61.42%   -0.05%     
==========================================
  Files          24       23       -1     
  Lines        2951     2950       -1     
==========================================
- Hits         1814     1812       -2     
- Misses       1137     1138       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martinfrances107
Copy link
Contributor Author

looking at the 14% drop in preformance ( A change to 1 µs to 1.2 µs ) well that looks completely to be expect from from repeatibility noise.

The +10% imrpovement ( from 287.2 ns to 259.4 ns ) is a welcome minor improvement

In short, I think being blocked on this is misguided.

@Geal
Copy link
Collaborator

Geal commented May 13, 2024

chill a bit. Benchmarks can be flaky, that's not an issue, and this change definitely cannot affect performance

@Geal Geal merged commit f87d397 into rust-bakery:main May 13, 2024
17 of 19 checks passed
@martinfrances107 martinfrances107 deleted the bump_MSRV branch May 14, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants