Implement semantic highlighting #10
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasperDeSutter
force-pushed
the
semantic-highlighting
branch
from
ead603b
to
1a2d2d3
Compare
|
There was a laggy implementation that I dropped, but this one looks good! Can you add a color for enum variants as well? They are now colored like functions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some serious limitations with the monaco version of vscode semantic highlighting.
There's no option to define any relation of token types, only a one-to-one mapping with highlighting. This means any custom types need an extra highlighting rule.
For this reason, I mapped custom ra SymbolKinds to existing monaco token types where it made sense. Modfiers don't do much out of the box, but I've added an underline rule for mutable variables as that is quite common.