Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing an iterable to splice_children #165

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow passing an iterable to splice_children #165

wants to merge 2 commits into from

Conversation

michaelvanstraten
Copy link

Should reduce two allocation when splicing children.

lnicola
lnicola approved these changes Jun 25, 2024
View reviewed changes
Copy link
Member

@lnicola lnicola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also bump the crate version number? I guess this isn't a breaking change.

@michaelvanstraten michaelvanstraten force-pushed the allow-passing-an-iterable-to-splice-children branch from e442c37 to faee543 Compare August 18, 2024 17:35
@michaelvanstraten
Copy link
Author

@lnicola, sorry for the delay, I've bumped the version number.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lnicola lnicola lnicola approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelvanstraten @lnicola