Fix for issue russross/blackfriday#239

[client9]

Fix for issue #239

This appears to also work in V1, although this PR is for V2

The following would confuse the - codeline as if it were a start of a nested list.

- line

    ```
    - codeline
    ```

The PR checks if a code fence is found, and don't use code to figure out if a list item has ended.

a code review is most welcome as I'm sure I'm missing something.

thanks!

n

[rtfb]

Looks good. How does it work with an unclosed code block? Like this:

- line

    ```
    - codeline

That's a malformed markdown, of course, and any behavior is almost as good as any other, but I want to make sure no source text gets omitted.

[client9]

I'll check... also, are there any issues with markdown parsing options, so that this needs to be turned on or off?

[rtfb]

are there any issues with markdown parsing options, so that this needs to be turned on or off?

Oh I'm glad you asked, because it slipped my attention. Looks like your fix should be conditional and do nothing with FencedCode turned off. With no fenced code, that seems to be a valid sublist.

And while you're at it, can you please add a test case for a non-fenced code block with sublist-like content?

[kaushalmodi]

Looking forward to this getting merged. Thanks for working on the fix!

[tfogo]

Hey @client9 are you planning on continuing work on this fix? It would be fantastic to have #239 fixed.

[client9]

@rtfb please re-view. Thanks to excellent work by @tfogo , we have the tests and conditional that you requested.

[rtfb]

LGTM, thanks a bunch, @client9 and @tfogo!!

[tfogo]

Awesome thanks @rtfb! Thanks @client9 for the heavy lifting!