Fix definition lists that contain other lists #264
Conversation
|
yes, this passes my tests |
|
nice short fix btw :) |
|
I don't completely understand how it works, and I'm not familiar with definition lists (I never use them myself). The change looks reasonable and passes all existing tests, and fixes this one, so LGTM. /cc @rtfb |
|
Tested it with my example from #235 (comment), and it works great. 👍 |
| @@ -1175,8 +1175,9 @@ gatherlines: | |||
|
|
|||
| if containsBlankLine { | |||
| // end the list if the type changed after a blank line | |||
There was a problem hiding this comment.
Is this comment still up to date despite the code change below? Just checking.
There was a problem hiding this comment.
Should probably be updated.
There was a problem hiding this comment.
Should I wait for your change or should I merge right away?
|
@rtfb, you can probably merge this now, and we can improve upon it later. My main concern is that this PR only solves half of the problem. If you have a Def List that contains differing adjacent lists, the adjacent lists are merged into a single list (which is the problem that I was originally trying to fix). I'm having a hard time understanding how to detect the nesting state to fix that problem and haven't had time to devote to fixing it. Example test case: |
Fixes #263
Ping @miekg @tianon