Skip to content

Commit

Permalink
hwmon: (ibmaem) Replace zero-length array with flexible-array member
Browse files Browse the repository at this point in the history
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:

struct foo {
        int stuff;
        struct boo array[];
};

By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertenly introduced[3] to the codebase from now on.

This issue was found with the help of Coccinelle.

[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] KSPP#21
[3] commit 7649773 ("cxgb3/l2t: Fix undefined behaviour")

Signed-off-by: Gustavo A. R. Silva <[email protected]>
Link: https://lore.kernel.org/r/20200211234237.GA26971@embeddedor
Signed-off-by: Guenter Roeck <[email protected]>
  • Loading branch information
GustavoARSilva authored and groeck committed Feb 12, 2020
1 parent db23dbe commit 2b4496c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/hwmon/ibmaem.c
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ struct aem_read_sensor_req {

struct aem_read_sensor_resp {
struct aem_iana_id id;
u8 bytes[0];
u8 bytes[];
} __packed;

/* Data structures to talk to the IPMI layer */
Expand Down

0 comments on commit 2b4496c

Please sign in to comment.