Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): resolve issue with PasswordInput component reveal icon #70

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

NeuroNexul
Copy link
Contributor

Description

I fixed the behaviour of the PasswordInput component in Edge Browser. The reveal icon wasn't hidden.

What type of PR is this? (check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 📝 Documentation Update
  • 🎨 Style
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build
  • 🔁 CI
  • 📦 Chore (Release)
  • ⏩ Revert

Mobile & Desktop Screenshots/Recordings

Copy link

changeset-bot bot commented Sep 17, 2024

⚠️ No Changeset found

Latest commit: 3b43c8a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

💥 An error occurred when fetching the changed packages and changesets in this PR
Some errors occurred when validating the changesets config:
The package or glob expression "sink" is specified in the `ignore` option but it is not found in the project. You may have misspelled the package name or provided an invalid glob expression. Note that glob expressions must be defined according to https://www.npmjs.com/package/micromatch.

Copy link

vercel bot commented Sep 17, 2024

@NeuroNexul is attempting to deploy a commit to the ruru-07 Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Sep 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ruru-ui ❌ Failed (Inspect) Sep 17, 2024 7:43am

@ruru-m07 ruru-m07 added bug Something isn't working component: update Updates or modifications to an existing component. labels Sep 17, 2024
@ruru-m07
Copy link
Owner

@NeuroNexul thanks for the PR bro. 🩷

Copy link
Owner

@ruru-m07 ruru-m07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm really so dumb.
thinkies

all changes look good ready to merge. 🚀

@ruru-m07 ruru-m07 merged commit 4b6070a into ruru-m07:main Sep 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working component: update Updates or modifications to an existing component.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants