Skip to content
This repository has been archived by the owner on Apr 25, 2024. It is now read-only.

Fix default boolean options always going to False #955

Merged
merged 5 commits into from
Mar 7, 2024

Conversation

nwatson22
Copy link
Member

@nwatson22 nwatson22 commented Mar 7, 2024

The parsed command line args are always getting False when no default is specified. However I had written code assuming that args would default to either None or the empty list for list type arguments..

@nwatson22 nwatson22 self-assigned this Mar 7, 2024
@ehildenb ehildenb marked this pull request as ready for review March 7, 2024 23:01
@ehildenb ehildenb merged commit be8907f into master Mar 7, 2024
12 checks passed
@ehildenb ehildenb deleted the noah/default-options-fix3 branch March 7, 2024 23:12
ehildenb added a commit that referenced this pull request Mar 8, 2024
rv-jenkins pushed a commit that referenced this pull request Mar 8, 2024
Two changes to options are reverted, which weren't able to be pushed
through KEVM:

- #955
- #916

---------

Co-authored-by: devops <[email protected]>
ehildenb pushed a commit that referenced this pull request Mar 11, 2024
Changes from:
- #916
- #955

---------

Co-authored-by: devops <[email protected]>
Co-authored-by: Tamás Tóth <[email protected]>
Baltoli pushed a commit to runtimeverification/k that referenced this pull request Apr 9, 2024
Two changes to options are reverted, which weren't able to be pushed
through KEVM:

- runtimeverification/pyk#955
- runtimeverification/pyk#916

---------

Co-authored-by: devops <[email protected]>
Baltoli pushed a commit to runtimeverification/k that referenced this pull request Apr 9, 2024
Changes from:
- runtimeverification/pyk#916
- runtimeverification/pyk#955

---------

Co-authored-by: devops <[email protected]>
Co-authored-by: Tamás Tóth <[email protected]>
Baltoli pushed a commit to runtimeverification/k that referenced this pull request Apr 9, 2024
…n/pyk#955)

The parsed command line args are always getting False when no `default`
is specified. However I had written code assuming that args would
default to either None or the empty list for list type arguments..

---------

Co-authored-by: devops <[email protected]>
Baltoli pushed a commit to runtimeverification/k that referenced this pull request Apr 9, 2024
Two changes to options are reverted, which weren't able to be pushed
through KEVM:

- runtimeverification/pyk#955
- runtimeverification/pyk#916

---------

Co-authored-by: devops <[email protected]>
Baltoli pushed a commit to runtimeverification/k that referenced this pull request Apr 9, 2024
Baltoli pushed a commit to runtimeverification/k that referenced this pull request Apr 9, 2024
…n/pyk#955)

The parsed command line args are always getting False when no `default`
is specified. However I had written code assuming that args would
default to either None or the empty list for list type arguments..

---------

Co-authored-by: devops <[email protected]>
Baltoli pushed a commit to runtimeverification/k that referenced this pull request Apr 9, 2024
Two changes to options are reverted, which weren't able to be pushed
through KEVM:

- runtimeverification/pyk#955
- runtimeverification/pyk#916

---------

Co-authored-by: devops <[email protected]>
Baltoli pushed a commit to runtimeverification/k that referenced this pull request Apr 9, 2024
Baltoli pushed a commit to runtimeverification/k that referenced this pull request Apr 10, 2024
…n/pyk#955)

The parsed command line args are always getting False when no `default`
is specified. However I had written code assuming that args would
default to either None or the empty list for list type arguments..

---------

Co-authored-by: devops <[email protected]>
Baltoli pushed a commit to runtimeverification/k that referenced this pull request Apr 10, 2024
Two changes to options are reverted, which weren't able to be pushed
through KEVM:

- runtimeverification/pyk#955
- runtimeverification/pyk#916

---------

Co-authored-by: devops <[email protected]>
Baltoli pushed a commit to runtimeverification/k that referenced this pull request Apr 10, 2024
Baltoli pushed a commit to runtimeverification/k that referenced this pull request Apr 10, 2024
…n/pyk#955)

The parsed command line args are always getting False when no `default`
is specified. However I had written code assuming that args would
default to either None or the empty list for list type arguments..

---------

Co-authored-by: devops <[email protected]>
Baltoli pushed a commit to runtimeverification/k that referenced this pull request Apr 10, 2024
Two changes to options are reverted, which weren't able to be pushed
through KEVM:

- runtimeverification/pyk#955
- runtimeverification/pyk#916

---------

Co-authored-by: devops <[email protected]>
Baltoli pushed a commit to runtimeverification/k that referenced this pull request Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants