Bump the ethereum-tests submodule #2506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
palinatolmach
approved these changes
Jul 3, 2024
Is it expected? |
No, I didn't get to the bottom of it yet. However, if I change the parsing rule of the the execution does not get stuck anymore. It has to be related to the updated encoding of the Before the update, the structure was "blocks" : [
{
"blockHeader" : {
"baseFeePerGas" : "",
"blobGasUsed" : "",
"bloom" : "",
"coinbase" : "",
"difficulty" : "",
"excessBlobGas" : "",
"extraData" : "",
"gasLimit" : "",
"gasUsed" : "",
"hash" : "",
"mixHash" : "",
"nonce" : "",
"number" : "",
"parentBeaconBlockRoot" : "",
"parentHash" : "",
"receiptTrie" : "",
"stateRoot" : "",
"timestamp" : "",
"transactionsTrie" : "",
"uncleHash" : "",
"withdrawalsRoot" : ""
},
"blocknumber" : "",
"rlp" : "",
"transactions" : [],
"uncleHeaders" : [],
"withdrawals" : []
}
],After the update, some tests use the same structure, but other tests have this new "blocks" : [
{
"expectException" : "",
"rlp" : "",
"rlp_decoded" : {
"blockHeader" : {
"baseFeePerGas" : "",
"blobGasUsed" : "",
"bloom" : "",
"coinbase" : "",
"difficulty" : "",
"excessBlobGas" : "",
"extraData" : "",
"gasLimit" : "",
"gasUsed" : "",
"hash" : "",
"mixHash" : "",
"nonce" : "",
"number" : "",
"parentBeaconBlockRoot" : "",
"parentHash" : "",
"receiptTrie" : "",
"stateRoot" : "",
"timestamp" : "",
"transactionsTrie" : "",
"uncleHash" : "",
"withdrawalsRoot" : ""
},
"blocknumber" : "",
"transactions" : [],
"uncleHeaders" : [],
"withdrawals" : []
}
}
]The order of the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumping the ethereum-tests submodule to latest release
Adding
Cancunschedule toschedules.md.Some changes to
driver.mdto support the updated test structure<blobGasUsed>,<excessBlobGas>,<beaconRoot>cells are added to decode the new rlp used in tests.Updated
failing.llvmlist:- skipping entire Cancun test suite from
BlockchainTests/GeneralStateTests/Pyspecs/cancun/, andBlockchainTests/GeneralStateTests/Cancun/- skipping individual tests that use the Cancun schedule.
- skipping
BlockchainTests/GeneralStateTests/Pyspecs/shanghai/eip4895_withdrawals/as withdrawals are not fully implemented.- (I) there are some new tests for already existing schedules that fail due to some gas costs
- (II) some tests are getting stuck on
<k> #halt ~> clear ~> run { .JSONs } ~> success .EthereumSimulation ~> .K </k>