Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: IPs and port mappings in pod get output #50

Merged
merged 4 commits into from
Apr 12, 2024
Merged

feat: IPs and port mappings in pod get output #50

merged 4 commits into from
Apr 12, 2024

Conversation

pw-git
Copy link
Contributor

@pw-git pw-git commented Sep 17, 2023

closes #39

@DireLines DireLines mentioned this pull request Dec 13, 2023
Merged
ef0xa
ef0xa reviewed Apr 12, 2024
View reviewed changes
cmd/pod/getPod.go Outdated Show resolved Hide resolved
ef0xa
ef0xa reviewed Apr 12, 2024
View reviewed changes
cmd/pod/getPod.go Outdated Show resolved Hide resolved
ef0xa
ef0xa reviewed Apr 12, 2024
View reviewed changes
cmd/pod/getPod.go Outdated Show resolved Hide resolved
DireLines
DireLines approved these changes Apr 12, 2024
View reviewed changes
Copy link
Collaborator

@DireLines DireLines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

took a while to get to this because we had to implement the same struct for our own purposes, so needed to combine your version and ours. But after checking, it'll work fine. Thanks!

@DireLines DireLines merged commit 83c2691 into runpod:main Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ef0xa ef0xa ef0xa left review comments

@DireLines DireLines DireLines approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show pod IP for get pod cmd
3 participants
@pw-git @DireLines @ef0xa