Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add workflow for installer tests #97

Merged
merged 3 commits into from
Dec 8, 2022
Merged

ci: add workflow for installer tests #97

merged 3 commits into from
Dec 8, 2022

Conversation

ningziwen
Copy link
Member

@ningziwen ningziwen commented Dec 7, 2022

Description of changes:
Add workflow to run installer tests.
The arm64 workflow has defects that will fail but can be used for initial setup. The follow-up manual steps are required to complete and clean up it. Issue: #106

Testing done:
Added push triggering to test it.
https://github.com/runfinch/finch/actions/runs/3635735114/jobs/6135091416

  • [ X ] I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Ziwen Ning <[email protected]>
Copy link
Member

@pendo324 pendo324 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a few questions, looks good overall

.github/workflows/release-installer.yaml Show resolved Hide resolved
.github/workflows/release-installer.yaml Show resolved Hide resolved
e2e/e2e_test.go Show resolved Hide resolved
.github/workflows/release-installer.yaml Show resolved Hide resolved
.github/workflows/release-installer.yaml Outdated Show resolved Hide resolved
Signed-off-by: Ziwen Ning <[email protected]>
Copy link
Member

@pendo324 pendo324 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for answering the comment questions

@ningziwen ningziwen merged commit e0bc86d into main Dec 8, 2022
@ningziwen ningziwen deleted the installer-release branch December 8, 2022 20:59
ahsan-z-khan pushed a commit to ahsan-z-khan/finch that referenced this pull request Jan 11, 2023
*Description of changes:*
Add workflow to run installer tests.
The arm64 workflow has defects that will fail but can be used for
initial setup. The follow-up manual steps are required to complete and
clean up it. Issue: runfinch#106

*Testing done:*
Added push triggering to test it.

https://github.com/runfinch/finch/actions/runs/3635735114/jobs/6135091416


- [ X ] I've reviewed the guidance in CONTRIBUTING.md


#### License Acceptance

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

Signed-off-by: Ziwen Ning <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants