-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add workflow for installer tests #97
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ningziwen
force-pushed
the
installer-release
branch
from
December 7, 2022 04:35
264e2e3
to
b4e2fb3
Compare
Signed-off-by: Ziwen Ning <[email protected]>
ningziwen
force-pushed
the
installer-release
branch
from
December 7, 2022 04:39
b4e2fb3
to
afca603
Compare
Signed-off-by: Ziwen Ning <[email protected]>
pendo324
reviewed
Dec 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just left a few questions, looks good overall
Signed-off-by: Ziwen Ning <[email protected]>
ningziwen
force-pushed
the
installer-release
branch
from
December 8, 2022 05:39
e6a51fd
to
218fdfd
Compare
davidhsingyuchen
approved these changes
Dec 8, 2022
pendo324
approved these changes
Dec 8, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for answering the comment questions
ahsan-z-khan
pushed a commit
to ahsan-z-khan/finch
that referenced
this pull request
Jan 11, 2023
*Description of changes:* Add workflow to run installer tests. The arm64 workflow has defects that will fail but can be used for initial setup. The follow-up manual steps are required to complete and clean up it. Issue: runfinch#106 *Testing done:* Added push triggering to test it. https://github.com/runfinch/finch/actions/runs/3635735114/jobs/6135091416 - [ X ] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Ziwen Ning <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add workflow to run installer tests.
The arm64 workflow has defects that will fail but can be used for initial setup. The follow-up manual steps are required to complete and clean up it. Issue: #106
Testing done:
Added push triggering to test it.
https://github.com/runfinch/finch/actions/runs/3635735114/jobs/6135091416
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.