chore: update Release-As version to 1.0.0 #674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release-As: 1.0.0 Signed-off-by: Justin Alvarez <[email protected]>
weikequ
approved these changes
Oct 31, 2023
|
As there's no file diff, I'm just going to override requirements here. Seems like the stalled out tests agree with that decision. |
|
I accidentally squashed the PR, which removed the very specific "Release-As:" commit message. Making a new PR now to actually get the updated release-please PR created |
1 task
pendo324
added a commit
that referenced
this pull request
Oct 31, 2023
Release-As: 1.0.0 Issue #, if available: see #674 (comment) *Description of changes:* - See #674 (comment) *Testing done:* - [x] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Justin Alvarez <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
It's been a year since Finch was originally released as a pre-1.0 (i.e. "unstable") project. Since then, the project has made a number of improvements to usability, compatibility, and feature-completeness. In addition to the more visible changes, there is also a suite of benchmarks and comprehensive e2e and unit tests which are executed on every single PR/commit. Through 13 releases, Finch has only had one unanticipated breaking change, as the result of a bug with the initial implementation of persistent disks (and even then, there was a migration path for users that may have been impacted).
Other changes that would have been breaking (e.g. #637 (comment)) have been caught by our e2e tests and reported/fixed upstream (many times with the fix proposed/implemented by Finch maintainers), instead of impacting Finch users. Because of all of this work, I believe that Finch is now ready to operate as stable software.
Description of changes:
Testing done:
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.