Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ecr creds helper and credential_process #510

Merged
merged 5 commits into from
Oct 31, 2023
Merged

fix: ecr creds helper and credential_process #510

merged 5 commits into from
Oct 31, 2023

Conversation

pendo324
Copy link
Member

@pendo324 pendo324 commented Jul 31, 2023 •
edited
Loading

Issue #, if available: #656

Description of changes:

  • invoke aws configure export-credentials --format process before running any commands that could need credentials (build, pull, push)
  • Pass the results into the VM in the as environment variables if the command returns output
    • Not every user may have the AWS CLI on the correct version to have the export-credentials --format process command, falls back to previous behavior in this case

TODO: add tests for new function

Testing done:

  • local testing

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

pendo324 added 2 commits July 31, 2023 15:08
@pendo324
fix: ecr creds helper and credential_process
3d34cfb 
Signed-off-by: Justin Alvarez <[email protected]>
@pendo324
fix go.sum
2081773 
Signed-off-by: Justin Alvarez <[email protected]>
@ollypom ollypom mentioned this pull request Oct 25, 2023
Closed
@pendo324
add test coverage
dd4cc56 
Signed-off-by: Justin Alvarez <[email protected]>
@pendo324
Merge branch 'main' into fix-creds_process
3e402d6 
Signed-off-by: Justin Alvarez <[email protected]>
@pendo324 pendo324 marked this pull request as ready for review October 30, 2023 23:22
austinvazquez
austinvazquez reviewed Oct 31, 2023
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@pendo324
update go-sdk
8d394c7 
Signed-off-by: Justin Alvarez <[email protected]>
austinvazquez
austinvazquez approved these changes Oct 31, 2023
View reviewed changes
Copy link
Member

@austinvazquez austinvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pendo324 pendo324 linked an issue Oct 31, 2023 that may be closed by this pull request
ecr-login credential helper doesn't pass through AWS variables #656
Closed
@pendo324 pendo324 merged commit 0525753 into runfinch:main Oct 31, 2023
14 checks passed
This was referenced Oct 31, 2023
Closed
Merged
pendo324 pushed a commit that referenced this pull request Nov 1, 2023
@github-actions
chore(main): release 1.0.0 (#676)
fe47ce2 
🤖 I have created a release *beep* *boop*
---


## [1.0.0](v0.9.0...v1.0.0)
(2023-10-31)


### chore

* update Release-As version to 1.0.0 (not-squashed)
([2c97323](2c97323))


### Bug Fixes

* ecr credential helper hash check
([#668](#668))
([4b1b0a2](4b1b0a2))
* ecr creds helper and credential_process
([#510](#510))
([0525753](0525753))
* improve creds helper UX
([#673](#673))
([bc238cf](bc238cf))
* run SOCI as a systemd service
([#667](#667))
([24fd649](24fd649))
* soci being reset on vm stop/start
([#672](#672))
([9df7d32](9df7d32))


### Build System or External Dependencies

* **deps:** Bump github.com/docker/cli from 24.0.6+incompatible to
24.0.7+incompatible
([#665](#665))
([43a57ff](43a57ff))
* **deps:** Bump github.com/docker/docker from 24.0.6+incompatible to
24.0.7+incompatible
([#666](#666))
([4e06d28](4e06d28))
* **deps:** Bump github.com/lima-vm/lima from 0.17.2 to 0.18.0
([#643](#643))
([f181b89](f181b89))
* **deps:** Bump github.com/onsi/gomega from 1.27.10 to 1.28.0
([#583](#583))
([9d1ad57](9d1ad57))
* **deps:** Bump github.com/runfinch/common-tests from 0.7.6 to 0.7.7
([#609](#609))
([e21ae83](e21ae83))
* **deps:** Bump github.com/runfinch/common-tests from 0.7.7 to 0.7.8
([#617](#617))
([4d942f5](4d942f5))
* **deps:** Bump github.com/shirou/gopsutil/v3 from 3.23.8 to 3.23.9
([#588](#588))
([20385b7](20385b7))
* **deps:** Bump golang.org/x/tools from 0.13.0 to 0.14.0
([#610](#610))
([8938cf3](8938cf3))
* **deps:** Bump google.golang.org/grpc from 1.53.0 to 1.56.3
([#658](#658))
([321487c](321487c))
* **deps:** Bump k8s.io/apimachinery from 0.28.2 to 0.28.3
([#652](#652))
([05f9d53](05f9d53))
* **deps:** Bump submodules and dependencies
([#637](#637))
([b094751](b094751))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Dec 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austinvazquez austinvazquez austinvazquez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ecr-login credential helper doesn't pass through AWS variables
2 participants
@pendo324 @austinvazquez