Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Adding instructions of how to authenticate to GCR/AR in FAQ #308

Closed
wants to merge 2 commits into from

Conversation

azhouwd
Copy link
Member

@azhouwd azhouwd commented Mar 21, 2023

Issue #, if available:

Description of changes:
Users are not able to authenticate to GCR/AR either by using service account key or authentication plugin.

Authenticating through service account key will save the credentials to an invalid path in the host OS - /root/.docker/config.json.

Authenticating through auth plugin - gcloud auth configure-docker is not working now. It is supported for nerdctl but that would require us to install gcloud cli and docker in the VM. The implementation of auth plugin would need more analysis.

More info: https://cloud.google.com/artifact-registry/docs/docker/authentication

This PR is to provide an instruction that gives users a quick workaround way to authenticate to GCR/AR.

Testing done:
Manual testing

  • I've reviewed the guidance in CONTRIBUTING.md

License Acceptance

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@azhouwd azhouwd changed the title Adding instructions of how to authenticate to GCR/AR in FAQ doc: Adding instructions of how to authenticate to GCR/AR in FAQ Mar 21, 2023
@azhouwd azhouwd changed the title doc: Adding instructions of how to authenticate to GCR/AR in FAQ docs: Adding instructions of how to authenticate to GCR/AR in FAQ Mar 21, 2023

Then shell into the VM by running the following command:
```sh
LIMA_HOME=/Applications/Finch/lima/data /Applications/Finch/lima/bin/limactl shell finch
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should not put vm shell as part of any user's workflow, unless it is a very temporary workaround. If we want to add this to doc, let's highlight it is workaround and link an issue for the right solution here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added link to the issue and specify it's a temp workaround way.

Signed-off-by: Ang Zhou <[email protected]>
@azhouwd azhouwd requested a review from ningziwen March 21, 2023 18:27
@azhouwd
Copy link
Member Author

azhouwd commented Mar 24, 2023

Closed this PR as the fix was moved to #315

@azhouwd azhouwd closed this Mar 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants