-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adds support bundles #210
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sam-berning
force-pushed
the
support-bundles
branch
3 times, most recently
from
February 15, 2023 01:31
d2fb229
to
e41a7c7
Compare
sam-berning
force-pushed
the
support-bundles
branch
3 times, most recently
from
March 9, 2023 01:55
e760c11
to
e4b1855
Compare
sam-berning
force-pushed
the
support-bundles
branch
9 times, most recently
from
March 24, 2023 22:21
5a169ef
to
c7706bb
Compare
ningziwen
reviewed
Mar 27, 2023
weikequ
reviewed
Mar 27, 2023
ningziwen
reviewed
Mar 27, 2023
ningziwen
reviewed
Mar 27, 2023
sam-berning
force-pushed
the
support-bundles
branch
from
March 28, 2023 23:30
c7706bb
to
ea7e96f
Compare
ningziwen
reviewed
Mar 28, 2023
ningziwen
reviewed
Mar 28, 2023
ningziwen
reviewed
Mar 28, 2023
ningziwen
reviewed
Mar 28, 2023
sam-berning
force-pushed
the
support-bundles
branch
from
March 29, 2023 00:26
ea7e96f
to
339ba91
Compare
@sam-berning Need to resolve the conflict files. |
sam-berning
force-pushed
the
support-bundles
branch
from
March 29, 2023 01:46
339ba91
to
24d1648
Compare
ningziwen
reviewed
Mar 29, 2023
sam-berning
force-pushed
the
support-bundles
branch
from
March 29, 2023 02:28
24d1648
to
7daf98c
Compare
Signed-off-by: Sam Berning <[email protected]>
sam-berning
force-pushed
the
support-bundles
branch
from
March 29, 2023 03:20
7daf98c
to
a70061b
Compare
ningziwen
approved these changes
Mar 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
. o ..
o . o o.o
...oo
__[]__
__|_o_o_o\__
\""""""""""/
\. .. . /
^^^^^^^^^^^^^^^^^^^^
weikequ
approved these changes
Mar 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
sam-berning
pushed a commit
that referenced
this pull request
Mar 29, 2023
🤖 I have created a release *beep* *boop* --- ## [0.5.0](v0.4.1...v0.5.0) (2023-03-29) ### Features * adds support bundles ([#210](#210)) ([cc6be65](cc6be65)) ### Bug Fixes * Correctly set and pick up environment variables ([#315](#315)) ([05227ce](05227ce)) * print debug logs after newline ([#273](#273)) ([8faa7de](8faa7de)) * print debug logs when lima disk command fails ([#270](#270)) ([78a3f50](78a3f50)) ### Experimental * **feat:** enable Virtualization.framework and Rosetta ([#282](#282)) ([fd3bf19](fd3bf19)) ### Build System or External Dependencies * clean up finch-core _output directory in clean target ([#290](#290)) ([4684a95](4684a95)) * **deps:** bump github.com/onsi/ginkgo/v2 from 2.8.4 to 2.9.0 ([#265](#265)) ([7e2d49e](7e2d49e)) * **deps:** bump github.com/onsi/ginkgo/v2 from 2.9.0 to 2.9.1 ([#285](#285)) ([d741a03](d741a03)) * **deps:** Bump github.com/onsi/gomega from 1.27.3 to 1.27.5 ([#312](#312)) ([e078234](e078234)) * **deps:** bump github.com/runfinch/common-tests from 0.6.1 to 0.6.2 ([#300](#300)) ([dd626a0](dd626a0)) * **deps:** bump github.com/spf13/afero from 1.9.4 to 1.9.5 ([#263](#263)) ([a0e277f](a0e277f)) * **deps:** bump golang.org/x/crypto from 0.6.0 to 0.7.0 ([#264](#264)) ([ec1c07f](ec1c07f)) * **deps:** bump golang.org/x/tools from 0.6.0 to 0.7.0 ([#268](#268)) ([8072e39](8072e39)) * **deps:** bump k8s.io/apimachinery from 0.26.2 to 0.26.3 ([#306](#306)) ([fe392cb](fe392cb)) * **deps:** Bump lima version ([#302](#302)) ([0269743](0269743)) * **deps:** Bump submodules ([#281](#281)) ([d4fd1f6](d4fd1f6)) * **deps:** Bump submodules ([#304](#304)) ([b38af9f](b38af9f)) * **deps:** Bump submodules ([#307](#307)) ([1a914ec](1a914ec)) * **deps:** Bump submodules ([#319](#319)) ([e671224](e671224)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sam Berning [email protected]
Issue #, if available:
Description of changes:
Allow users to generate a support bundle, a collection of Finch-related logs and configs that will help debug issues.
Testing done:
Unit & manual testing
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.