Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persistent volume support #77

Closed
pendo324 opened this issue Dec 1, 2022 · 0 comments · Fixed by #133
Closed

Persistent volume support #77

pendo324 opened this issue Dec 1, 2022 · 0 comments · Fixed by #133
Assignees
@sam-berning
Labels
enhancement New feature or request

Comments

@pendo324
Copy link
Member

pendo324 commented Dec 1, 2022

What is the problem you're trying to solve?.
Lima recently merged support for persistent data volumes, we should enable it in Finch by default so data can persist between different VM initializations.

Describe the feature you'd like
Add persistent volume creation and management to Finch, along with scripts that mount the containerd directories onto the volume.

Additional context
Add any other context or screenshots about the feature request here.
@pendo324 pendo324 moved this to v0.2.0 in Engineering Roadmap Dec 1, 2022
@sam-berning sam-berning added the enhancement New feature or request label Dec 2, 2022
@sam-berning sam-berning mentioned this issue Dec 27, 2022
Merged
1 task
@ahsan-z-khan ahsan-z-khan linked a pull request Jan 3, 2023 that will close this issue
feat: saves containerd user data to a persistent disk #133
Merged
1 task
sam-berning added a commit that referenced this issue Jan 7, 2023
@sam-berning
feat: saves containerd user data to a persistent disk (#133)
fccb4f3 
this allows users to retain downloaded images, containers, etc. across
new installations of finch

Signed-off-by: Sam Berning <[email protected]>

Issue #, if available: #77

*Description of changes:*

- Adds a new package for managing the user data persistent disk
- Checks disk configuration & creates disk if necessary on `finch vm
init`
- Attaches disk whenever the VM starts

*Testing done:*
- Unit testing on `disk` and `cmd/finch`
- Manual testing

*Open questions:*
- Should we also check the configuration on `finch vm start`?



- [x] I've reviewed the guidance in CONTRIBUTING.md


#### License Acceptance

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

Signed-off-by: Sam Berning <[email protected]>
ahsan-z-khan pushed a commit to ahsan-z-khan/finch that referenced this issue Jan 11, 2023
@sam-berning @ahsan-z-khan
feat: saves containerd user data to a persistent disk (runfinch#133)
6a75f5d 
this allows users to retain downloaded images, containers, etc. across
new installations of finch

Signed-off-by: Sam Berning <[email protected]>

Issue #, if available: runfinch#77

*Description of changes:*

- Adds a new package for managing the user data persistent disk
- Checks disk configuration & creates disk if necessary on `finch vm
init`
- Attaches disk whenever the VM starts

*Testing done:*
- Unit testing on `disk` and `cmd/finch`
- Manual testing

*Open questions:*
- Should we also check the configuration on `finch vm start`?



- [x] I've reviewed the guidance in CONTRIBUTING.md


#### License Acceptance

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

Signed-off-by: Sam Berning <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sam-berning sam-berning

Labels
enhancement New feature or request
Projects
Engineering Roadmap
Status: v0.2.0
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: saves containerd user data to a persistent disk sam-berning/finch
2 participants
@pendo324 @sam-berning