Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fedora image downloaded on runners are not cleaned up after CI or build #262

Closed
KevinLiAWS opened this issue Mar 3, 2023 · 0 comments
Closed

Fedora image downloaded on runners are not cleaned up after CI or build #262

KevinLiAWS opened this issue Mar 3, 2023 · 0 comments
Assignees
@AnqiPang
Labels
bug Something isn't working

Comments

@KevinLiAWS
Copy link
Contributor

Describe the bug
After switch Core to submodule, the Fedora image is downloaded to:
/Users/ec2-user/ar/_work/finch/finch/deps/finch-core/downloads/os
This directory is not cleaned up by the make clean command, so that Finch build action will package all the images inside of this directory.

Steps to reproduce
Update Fedora image without cleaning up the old download on runners, the upload build action will package all the images. The build size significantly increases above 1GB

Expected behavior
The old image downloaded should be cleaned up.
@KevinLiAWS KevinLiAWS added the bug Something isn't working label Mar 3, 2023
@AnqiPang AnqiPang self-assigned this Mar 3, 2023
@AnqiPang AnqiPang mentioned this issue Mar 14, 2023
Merged
1 task
AnqiPang added a commit that referenced this issue Mar 20, 2023
@AnqiPang
build: clean up finch-core _output directory in clean target (#290)
4684a95 
Issue #, if available:
#262
*Description of changes:*

*Testing done:*



- [x] I've reviewed the guidance in CONTRIBUTING.md


#### License Acceptance

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

Signed-off-by: Anqi Pang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AnqiPang AnqiPang

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AnqiPang @KevinLiAWS