Skip to content

Commit

Permalink
fix(Makefile): use POSIX tar syntax for stdin (#529)
Browse files Browse the repository at this point in the history
Issue #, if available:

*Description of changes:*

In x mode, all POSIX-compliant versions of tar require -f to read the
input archive from somewhere other than the default. Some machines (e.g.
Windows) may not have the GNU version of tar installed.

*Testing done:*



- [X] I've reviewed the guidance in CONTRIBUTING.md


#### License Acceptance

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

Signed-off-by: Gavin Inglis <[email protected]>
  • Loading branch information
ginglis13 authored Sep 12, 2023
1 parent 21bb893 commit e222131
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ finch-core:
"$(MAKE)"

mkdir -p _output
cd deps/finch-core/_output && tar c * | tar Cvx $(OUTDIR)
cd deps/finch-core/_output && tar -cf - * | tar -xvf - -C $(OUTDIR)
rm -rf $(OUTDIR)/lima-template

.PHONY: local-core
Expand All @@ -80,8 +80,8 @@ local-core:
"$(MAKE)" lima lima-socket-vmnet

mkdir -p _output
cd deps/finch-core/_output && tar c * | tar Cvx $(OUTDIR)
cd deps/finch-core/src/lima/_output && tar c * | tar Cvx $(OUTDIR)/lima
cd deps/finch-core/_output && tar -cf - * | tar -xvf - -C $(OUTDIR)
cd deps/finch-core/src/lima/_output && tar -cf - * | tar -xvf - -C $(OUTDIR)/lima
rm -rf $(OUTDIR)/lima-template

.PHONY: lima-and-qemu
Expand Down Expand Up @@ -121,7 +121,7 @@ config.yaml:
.PHONY: copy
copy:
mkdir -p $(DEST)
(cd _output && tar c * | tar Cvx $(DEST) )
(cd _output && tar -cf - * | tar -xvf - -C $(DEST) )

.PHONY: install
install: copy
Expand Down

0 comments on commit e222131

Please sign in to comment.