Skip to content

Commit

Permalink
test: remove rosetta from installer test (#149)
Browse files Browse the repository at this point in the history
Signed-off-by: Ziwen Ning <[email protected]>

Issue #, if available:
#105

*Description of changes:*
Remove Rosetta from installer test as it is fixed in installer

*Testing done:*
Tested with the latest installer


- [ X ] I've reviewed the guidance in CONTRIBUTING.md


#### License Acceptance

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.

Signed-off-by: Ziwen Ning <[email protected]>
  • Loading branch information
ningziwen authored Jan 13, 2023
1 parent 8cacb1f commit 8ee5763
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions .github/workflows/release-installer.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,7 @@ jobs:
run: |
aws s3 cp s3://${{ secrets.INSTALLER_PRIVATE_BUCKET_NAME }}/Finch-${GITHUB_REF_NAME}-aarch64.pkg Finch-${GITHUB_REF_NAME}-aarch64.pkg
- name: Silently install
# Rosetta is only needed in arm64. Currently the installer command will fail to install without Rosetta.
# TODO: Remove Rosetta command when the installer is fixed. (https://github.com/runfinch/finch/issues/105)
run: |
echo 'A' | sudo softwareupdate --install-rosetta
sudo installer -pkg Finch-${GITHUB_REF_NAME}-aarch64.pkg -target /
run: sudo installer -pkg Finch-${GITHUB_REF_NAME}-aarch64.pkg -target /
- name: Run e2e tests
run: INSTALLED=true make test-e2e
- name: Silently uninstall
Expand Down

0 comments on commit 8ee5763

Please sign in to comment.