ci: track main branch of lima submodule #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vishwas Siravara <[email protected]>
|
Would it be better to track a particular "known good" commit, rather than just taking all changes on the master branch? |
sam-berning
reviewed
Sep 20, 2023
Signed-off-by: Vishwas Siravara <[email protected]>
austinvazquez
approved these changes
Sep 20, 2023
ginglis13
approved these changes
Sep 20, 2023
pendo324
approved these changes
Sep 20, 2023
sam-berning
approved these changes
Sep 20, 2023
|
Is this temporary? Should we open a tracking issue to revert back to using the latest tagged release in CI ? Otherwise we'll have to keep manually updating the commit we checkout. |
1 task
sam-berning
added a commit
that referenced
this pull request
Sep 21, 2023
#173) …s from 0.7.4 to 0.7.6 in /e2e Issue #, if available: *Description of changes:* In order to get `finch-core` tests working again in one go, I'm bumping the submodules and the tests in one PR. This will allow us to immediately use the changes in Lima + Nerdctl. For the submodules, I pinned Lima to b357e260b1a03f0142c63b3e071b784ae66d5d34 as [decided previously](#162). *Testing done:* ``` make test-e2e ``` tests all passed, except for a few timeouts - [x] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Sam Berning <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Track a known good commit main branch of lima submodule vs latest tag.
Testing done:
Yes
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.