feat: Tests for bind mounts #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vishwas Siravara <[email protected]>
vsiravar
force-pushed
the
vsiravar/tests-for-bind-mounts
branch
from
30f8954 to
2decb9f
Compare
ningziwen
reviewed
May 26, 2023
Signed-off-by: Vishwas Siravara <[email protected]>
Signed-off-by: Vishwas Siravara <[email protected]>
Signed-off-by: Vishwas Siravara <[email protected]>
pendo324
approved these changes
May 26, 2023
ningziwen
approved these changes
May 26, 2023
vsiravar
pushed a commit
that referenced
this pull request
May 26, 2023
🤖 I have created a release *beep* *boop* --- ## [0.7.0](v0.6.5...v0.7.0) (2023-05-26) ### Features * Tests for bind mounts ([#66](#66)) ([22a7f7e](22a7f7e)) * verify the result of finch inspect has State.Status and State.Error ([#64](#64)) ([b761a7a](b761a7a)) ### Build System or External Dependencies * **deps:** bump github.com/onsi/ginkgo/v2 from 2.9.2 to 2.9.5 ([#62](#62)) ([0bd0901](0bd0901)) * **deps:** bump github.com/onsi/gomega from 1.27.5 to 1.27.6 ([#54](#54)) ([72120b5](72120b5)) * **deps:** bump github.com/onsi/gomega from 1.27.6 to 1.27.7 ([#65](#65)) ([590a984](590a984)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
ningziwen
added a commit
to runfinch/finch
that referenced
this pull request
May 26, 2023
Issue #, if available: #418 *Description of changes:* Sort volume args in DOCKER_COMPAT mode *Testing done:* Unit tests and new e2e tests. runfinch/common-tests#66 - [ X ] I've reviewed the guidance in CONTRIBUTING.md #### License Acceptance By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license. Signed-off-by: Ziwen Ning <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Test functioning of nested bind mounts with and without $DOCKER_COMAPT set.
Testing done:
Yes locally.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.